Failed to update demo-kendo

[adriatic]

I forgot how to build the content of the sample folder in the context of urelia-kendoui-bridge, since running gulp watch in the sample folder fails because there is no gulpfile.js.

So here is my status

1. I fixed the samples.json file
2. I cloned https://github.com/aurelia-ui-toolkits/demo-kendo and fixed controls.html in that repo. Tested 1. and 2. locally - all fine.
3. In order to stay compliant with the build process for catalog, I did not use this https://github.com/aurelia-ui-toolkits/demo-kendo repo to update the Catalog - for the reason explained in the first paragraph above.

In order to make you the Catalog update as simple as possible I added the fix 2 above to urelia-kendoui-bridge - see https://github.com/aurelia-ui-toolkits/aurelia-kendoui-bridge/commit/46c32c1ecbf466053cd9e6bc6e4c6c85757ff477

If you cannot do this early on your Monday, I will post the message in the gitter channel that the Pivot Grid is accessible via http://aurelia-ui-toolkits.github.io/demo-kendo/#/samples/pivot-grid-basic-use

[adriatic]

If you cannot do this early on your Monday, I will post the message in the gitter channel that the Pivot Grid is accessible via http://aurelia-ui-toolkits.github.io/demo-kendo/#/samples/pivot-grid-basic-use

Done: :point_up: November 20, 2017 8:32 AM

---

On

I forgot how to build the content of the sample folder in the context of urelia-kendoui-bridge ...

I do not understand why do I need to update the code of the Catalog in the Bridge first - without being able to verify the fixes in the context of the bridge and then copy that same code to the Catalog repository in order to be able to use the Gulp deploy there ???

[JeroenVinke]

when you run the catalog from the aurelia-kendoui-bridge repo (gulp watch) you're using the local aurelia-kendoui-bridge (this folder) . The catalog in the demo-kendo repo uses the version marked 'latest' released on NPM. This is why changes to the catalog are made in aurelia-kendoui-bridge first, so that if you've made any changes to the plugin you'll be able to confirm that the catalog still works

An advantage of this setup is that demo-kendo is a real application, with no magic setup at all (it doesn't use a local version of the bridge or anything). It's an application that use aurelia-kendoui-bridge from NPM, so that if the release got messed up there's a chance that you'll catch it when you try to run demo-kendo

In this case though, you aren't changing anything to the bridge so there isn't any advantage here of making the changes in the aurelia-kendoui-bridge repo first. You just need to make sure that changes are both in demo-kendo and aurelia-kendoui-bridge, because if the change is only made in demo-kendo and not the aurelia-kendoui-bridge repo then I might overwrite the change in demo-kendo when I copy from aurelia-kendoui-bridge to demo-kendo

[adriatic]

when you run the catalog from the aurelia-kendoui-bridge repo (gulp watch) you're using the local aurelia-kendoui-bridge (this folder)

Seeing your writing, I instantly recalled being a big proponent of this approach (it was Charles that explained it first, I believe). Thanks for causing my memory refresh.

In this case though, you aren't changing anything to the bridge so there isn't any advantage here of making the changes in the aurelia-kendoui-bridge repo first. You just need to make sure that changes are both in demo-kendo and aurelia-kendoui-bridge, because if the change is only made in demo-kendo and not the aurelia-kendoui-bridge repo then I might overwrite the change in demo-kendo when I copy from aurelia-kendoui-bridge to demo-kendo

Yes, that is the situation at hand - and I have made the needed changes in aurelia-kendoui-bridge repo. To ensure consistency, I will overwrite these same changes in the catalog.

So, I will deploy the catalog as well.

Thanks for this discussion