search

aurelia-v-grid / vGrid

Aurelia-v-grid - npm source
MIT License
49 stars 10 forks source link

Refactory to v-sort and v-filter works #61

Closed vegarringdal closed 7 years ago

vegarringdal commented 7 years ago

@Thanood, Would like to get some quick on some changes Ive been considering.

Been thinking about refactor a little how we use v-sort & col-sort, and v-filter & col-filter Was thinking something like this

col-filter & v-filter col-filter="field:XXX;operator:XX;converter:XXXX;keydown:true" (the v-filter will be the same, but since that is used in custom html you also need to add "rowRef." to field

col-sort & v-sort col-sort="field:XXX;asc:false;" (v-sort same with the "rowRef", the default-asc is for forcing the grid to sort desc on first click)

This will give these attributes more control, and be much easier to expand later.

Thanood commented 7 years ago

Good idea, I like it. :smiley: While you're at it, would you consider naming these attributes the same? So the usage is more consistent? I don't know if it's possible since these are two different attributes/files.

vegarringdal commented 7 years ago

1 part is attribute, "col" part is bindables on a custom element v-grid-col and used with the v-column binding. So cant have them named the same "col" part is only used with simple html part. The "col" part is also just so I know how to create the custom html you can define your self if you want.

vegarringdal commented 7 years ago

@Thanood this is added now, just so you know update will break you grid if you dont update adding field etc

vegarringdal commented 7 years ago

replaced by temp gitbook: https://github.com/vegarringdal/vGrid/issues/69