aurelia-v-grid / vGrid

Aurelia-v-grid - npm source
MIT License
49 stars 10 forks source link

overrideContext <- might need to rename internals #94

Closed vegarringdal closed 5 years ago

vegarringdal commented 6 years ago

overrideContext

https://github.com/vegarringdal/vGrid/blob/dev-rebuild/src/grid/contextMenu.ts#L124-L133

Might need to rename some of the variables here, since it will be very easy to override by accident. Since entire class is binded to the menu I need to consider prefixing evything with avg_

I need to look if I have this issue elsewhere too

Other option can be that I force user to define a object in class using the grrid, that way its harder to miss, and if component have many grids you wont crash