There are some issues with this conditional.
Note that the conditional is inside a function that is called only if aurelia-app has no value (ex: beginner kits).
the condition is always true because location.protocolincludes the final ":" (http: or https:)
location.protocol isn't good for checking if running locally (ex: localhost) because for both Firefox and Chrome location.protocol === 'http:' // true on localhost
I suggest one of the following:
remove the conditional (keep the developmentLogging() call)
use location.port instead of location.protocol.
Will submit a PR with the change.
@EisenbergEffect
EisenbergEffect
commented
8 years ago
There are some issues with this conditional. Note that the conditional is inside a function that is called only if
aurelia-apphas no value (ex: beginner kits).truebecauselocation.protocolincludes the final ":" (http:orhttps:)location.protocolisn't good for checking if running locally (ex:localhost) because for both Firefox and Chromelocation.protocol === 'http:' // trueonlocalhostI suggest one of the following:
developmentLogging()call)location.portinstead oflocation.protocol.Will submit a PR with the change. @EisenbergEffect