Revision missing on html import template bundle

[fragsalat]

I'm submitting a bug report

• Library Version: 0.4.0

Please tell us about your environment:

• Operating System: Ubuntu 16.04
• Node Version: 6.1.1
• NPM Version: 3.10.3
• JSPM OR Webpack AND Version JSPM 0.16.45
• Browser: all
• Language: all

Current behavior: A html bundle using the config property htmlimport: true and the option rev: true doesn't append a revision number to the file name. See config below.

Expected/desired behavior: The filename of the bundled html templates contains a generated revision number.

• What is the expected behavior? Is this question doubled in the template for any reason? May you should remove one of those.
• What is the motivation / use case for changing the behavior? Without a revision number the browser cache can deliver an outdated version of that html file even when it changed. This can break the application layout.

Here's my example config:

'view-bundle': {
    'htmlimport': true,
    'includes': [
        'app/**/*.html',
        'some-jspm-package/some-webcomponent-which-is-by-the-way-not-included-in-the-bundle-for-any-reason.html'
    ],
    'options': {
        'inject': true,
        'minify': true,
        'rev': true
    }
}

To fix that problem the utility function getOutFileName(content: Sting, fileName: String, revision: Boolean) should be used to get the filename for the bundle. Also the check if the bundle exists already should be done after bundling because the content is required to generate the hash and the hash is required to generate the filename and the filename is required to check if the file exists obviously^^

[EisenbergEffect]

@ahmedshuhel Please review this bug and the associated PR to see if we can get a fix released.

[ahmedshuhel]

On it

[ahmedshuhel]

We will have this feature in the next release.