search

aurelia / bundler

A library for bundling JavaScript, HTML and CSS for use with SystemJS.
MIT License
37 stars 25 forks source link

Configuration serialization does not work #59

Closed hexawyz closed 8 years ago

hexawyz commented 8 years ago

I'm having a hard time making bundle tasks from https://github.com/aurelia/skeleton-navigation work on my system, so I decided to upgrade to aurelia-bundler 0.2.1. After that, when running "gulp bundle" or "gulp unbundle" I got this error:

TypeError: needs a 'context' argument.
    at readConfig ([…]\node_modules\aurelia-bundler\dist\config-serializer.js:25:6)

This seems to come from bundler/lib/config-serializer.js:16. When replacing "sandbox" with "ctx", the code works again. (Still not bundling anything for me, but this at least fixes the unbundle task)

ahmedshuhel commented 8 years ago

We had a similar issue here. Try these things first and let us know again.

EisenbergEffect commented 8 years ago

If this turns out to be a recurring issue we may need to add a note to the docs. It's basically a node version issue right? On Jan 10, 2016 12:57 PM, "Shuhel Ahmed" notifications@github.com wrote:

We had a similar issue here https://github.com/aurelia/bundler/issues/54. Try these things first and let us know again.

— Reply to this email directly or view it on GitHub https://github.com/aurelia/bundler/issues/59#issuecomment-170374582.

hexawyz commented 8 years ago

It seems I was indeed running a very old version of node… Updating it to the latest version seems to solve the problem :) Thanks !

ahmedshuhel commented 8 years ago

@EisenbergEffect Yes. It's a version issue. We need to know the oldest node version that works and then we can add it to doc. Or, we can say, "Please use the latest version of NodeJS"

EisenbergEffect commented 8 years ago

How best can we determine the oldest version that works?

ahmedshuhel commented 8 years ago

I believe v4 will work. I am running v5 on my machine currently. The problem is with the vm module. That got some changes in the last few versions of node. I will probably need to set nvm and try a few version myself.

Raising an issue for that,

riddla commented 8 years ago

Maybe you could add a hint to the extended Visual Studio configuration for Node.js also within the docs? https://blogs.msdn.microsoft.com/webdev/2015/03/19/customize-external-web-tools-in-visual-studio-2015/ as mentioned in https://github.com/aurelia/bundler/issues/54#issuecomment-220566146?