aurelia / dialog

A dialog plugin for Aurelia.
MIT License
106 stars 115 forks source link

Trucante long text in display table #343

Closed victorDivino closed 3 years ago

victorDivino commented 6 years ago

The table should not grow outside the width of the screen, if displays text (potentially long), which must be truncated when necessary, so that the text fits into the child elements, which is adapted to the width of the table, which may not be larger than the width of the screen.

bad fix

CLAassistant commented 6 years ago

CLA assistant check
All committers have signed the CLA.

Alexander-Taran commented 6 years ago

Could you attach 2 screenshots for a bad rendering before and after fix?

victorDivino commented 6 years ago

bad fix

victorDivino commented 6 years ago

Without table-layout: fixed

pt1

With table-layout: fixed

pt2

As you can see, the modal width does't grow outside the screen when we use fixed layout!

Emails were blured for security purpose

Alexander-Taran commented 6 years ago

Not sure about this. @StrahilKazlachev what do you think?

AlbertoMonteiro commented 6 years ago

@Alexander-Taran take look here: https://css-tricks.com/fixing-tables-long-strings/ You can see in first two samples, that when table does not have the layout fixed, the width of table, can be higher of the table's parent element, in the second sample, using fixed layout the last 3 tables that in previous sample had overflowed, doest do that anymore.

Alexander-Taran commented 6 years ago

Yeah Chris Coyier is the man (-: @StrahilKazlachev & @EisenbergEffect pretty safe to merge

unless we have sevaral 'rows' for the table that is dialog otherwise width will be calculated by 1st row

EisenbergEffect commented 6 years ago

Looks good to me. @StrahilKazlachev Can we get this in? Any objections?

JSeligsohn commented 4 years ago

Any reason this wasn't merged? I just discovered this fix on my own and would be nice if had been merged already to save me (and others) from a headache :)