search

aurelia / dialog

A dialog plugin for Aurelia.
MIT License
106 stars 115 forks source link

Cannot find name 'AddEventListenerOptions'. #371

Closed falconmick closed 5 years ago

falconmick commented 5 years ago

I'm submitting a bug report

Please tell us about your environment:

Current behavior: Build failing due to typing issue originating out of this packages typings: typings\modules\aurelia-dialog\index.d.ts(1576,44): error TS2304: Cannot find name 'AddEventListenerOptions'.

Expected/desired behavior: to not get typings errors

bigopon commented 5 years ago

@falconmick Can you at least update to latest version of v1? v1.0.0-beta.x is a bit hard to support/debug now

bigopon commented 5 years ago

If you still get the same error with v1, please help comment here

falconmick commented 5 years ago

I'll get back to you. It's an older project and nobody left at the company knows it so It's kinda not a fun day when this stops working! Thanks for getting back to me

StrahilKazlachev commented 5 years ago

There is something strange here. First there is no such type - AddEventListenerOptions, used in the 1.0.0-beta.3.0.1 types. Second, this is a DOM API, I have no recollection of having anything explicitly typed with it. Third, what is this line number - 1576? The .d.ts file for this version is only 231 lines.

typings\modules\aurelia-dialog\index.d.ts(1576,44)

I would check from where the types file is acquired.

rajansen commented 5 years ago

looks like aurelia-templating.d.ts is imported from the latest dist, see this commit: https://github.com/aurelia/templating/commit/d2da4143389291077a7efd05d960f5ed45dcc0cf#diff-d4ec8ae7ec00cac9b4cc47b504a8882c

StrahilKazlachev commented 5 years ago

So this issue can be closed, since it's not in the dialog?

falconmick commented 5 years ago

Issue must have been due to build server and dev machines being on a certain typescript version and then somthing made both of em jump to another as the issues were caused by wrong versions of typescript