Closed bigopon closed 5 years ago
CI failing because it can't auto bump the .rc
version
An update: adjust useRenderer
interface so that it can have backward compat, while enabling ease of use with bundler/code:
useRenderer(renderer: RenderStatic, settings);
to
useRenderer(renderer: RenderStatic | Promise<RendererStatic> | 'ux' | 'native', settings);
We just give 2 string literal values as a hint for what is provided by default. thoughts?
I've update the build so that we now have css in less
auto built whenever source is built. Also split CSS into its separate chunk so if one prefers not to use default CSS or use native dialog renderer, a lot of unused code can be avoided.
@EisenbergEffect this is ready to go
As usual, amazing work @bigopon ! I like the api with the string literals for convenience while still enabling custom renderer instances. Nice touch.
cherry picked changes from @zewa666 for keyboard event type
cherry picked changes from @timfish for native dialog renderer
rename default dialog renderer to ux-dialog-renderer (bold file name and class name), still keep old export
Breaking change: modify useRenderer method to accept
'ux' | 'native'
for picking a dialog renderer, instead of asking for impl directlymodify build to use rollup for all builds, example:![image](https://user-images.githubusercontent.com/9994529/57572065-3c0e6b00-7459-11e9-8807-77878ba65779.png)
modify typings build: put all in![image](https://user-images.githubusercontent.com/9994529/57572168-0e75f180-745a-11e9-9599-1787ec3b0534.png)
types
folder. It looks like thisadd es2017 dist (not really different from es2015, just consistent with the newer build from other repos)
use karma + webpack for test instead of requirejs
remove doc scripts (couldn't figure out why typedoc is upset)
For the breaking change related to
useRenderer
, I think it's a good compromise, (as @3cp would love to say). If folks complain, we can add change it back to:from
@EisenbergEffect @RomkeVdMeulen @StrahilKazlachev
close #335