search

aurelia / dialog

A dialog plugin for Aurelia.
MIT License
106 stars 115 forks source link

typings.json does not define dependency versions #377

Open Mobe91 opened 5 years ago

Mobe91 commented 5 years ago

Current behavior: When installing typings using e.g. typings install --save github:aurelia/dialog#1.1.0, the typings tool uses the master version of dependencies defined in aurelia/dialog/typings.json because no versions are defined. This just broke my build unexpectedly because the typings in the dependency masters changed.

Expected/desired behavior: aurelia/dialog/typings.json should specify dependency versions.

joelowrance commented 5 years ago

@Mobe91 Are you seeing errors like the ones at the bottom of this issue?

https://github.com/aurelia/dependency-injection/issues/178

typings\modules\aurelia-dialog\index.d.ts(2577,1): error TS2668: 'export' modifier cannot be applied to ambient modules and module augmentations since they are always visible.
typings\modules\aurelia-dialog\index.d.ts(2632,170): error TS2536: Type 'number' cannot be used to index type 'TArgs'.
typings\modules\aurelia-dialog\index.d.ts(2638,122): error TS2536: Type 'number' cannot be used to index type 'TArgs'.
typings\modules\aurelia-validation\index.d.ts(496,9): error TS2707: Generic type 'Lazy<TBase, TImpl, TArgs>' requires between 1 and 3
type arguments.
Mobe91 commented 5 years ago

@joelowrance exactly