search

aurelia / dialog

A dialog plugin for Aurelia.
MIT License
106 stars 115 forks source link

DialogCloseError is not exposed in typings #382

Closed silbinarywolf closed 4 years ago

silbinarywolf commented 4 years ago

I'm submitting a bug report

Please tell us about your environment:

Current behavior: Cannot import DialogCloseResult, like so:

import { DialogCloseResult } from 'aurelia-dialog';

Looks like a mistake where the following file isn't importing the generated type info:

https://github.com/aurelia/dialog/blob/master/dist/types/aurelia-dialog.d.ts
https://github.com/aurelia/dialog/blob/master/dist/types/dialog-close-error.d.ts

Expected/desired behavior: I should be able to import this type information.

bigopon commented 4 years ago

@silbinarywolf thanks for filing this. This is probably because of merging v2 to master work. Would be nice if you could help PR to fix this 👍

StrahilKazlachev commented 4 years ago

It only needs a reexport added to aurelia-dialog.ts.