search

aurelia / documentation

The documentation for Aurelia.
MIT License
105 stars 110 forks source link

router-view swap-order attribute is not documented #310

Closed dkent600 closed 6 years ago

dkent600 commented 7 years ago

I am trying to get animations working, for between routes and for showing and hiding dialogs, and am having issues with both (using aurelia-animator-velocity v 1.0.1).

So I've been googling to find documentation about animation that might help me. I have turned up documents alluding to using "swap-order" to improve how animations work, at least with respect to routing.

The suggested code would supposedly look something like this:

<router-view swap-order="with"></router-view>

However, I can find no documentation of this feature in the aurelia hub documentation. Searching for "swap-order" turns up nothing.

When I dig around in the Aurelia code itself, I find stuff about ViewPortInstruction and "SwapStrategies". Searching in the hub for "swap" turns up something in the API under "templating-router :: RouterView" referring to viewPortInstruction, but it really doesn't help beyond that.

EisenbergEffect commented 7 years ago

Would you be interested in submitting a PR?

dkent600 commented 7 years ago

@EisenbergEffect I would if I had any idea what swap-order does.

If you want to put an explanation here, I could create a PR.

dkent600 commented 7 years ago

I may do the research to figure out what it swap-order does

dkent600 commented 7 years ago

@EisenbergEffect If you want I might also be able to work #314 in the same PR. Being attributes of the same custom element (router-view) and side-by-side in the same document, it would be efficient to make the changes together. What do you think?

EisenbergEffect commented 7 years ago

Sounds great!

On Dec 17, 2016 11:23 AM, "Doug Kent" notifications@github.com wrote:

If you want I might also be able to work #314 https://github.com/aurelia/documentation/issues/314 in the same PR. Being attributes of the same custom element (router-view) and side-by-side in the same document, it would be efficient to make the changes together. What do you think?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/aurelia/documentation/issues/310#issuecomment-267771459, or mute the thread https://github.com/notifications/unsubscribe-auth/AAIBnQzshVzESBSqPXFDh-a11MnHI4yPks5rJAxxgaJpZM4LDrCG .

Alexander-Taran commented 6 years ago

merged

maybe can be closed