search

aurelia / documentation

The documentation for Aurelia.
MIT License
105 stars 111 forks source link

Fix final version of app.html w/loading-indicator #379

Closed tebruno99 closed 5 years ago

tebruno99 commented 5 years ago

There is a typo so the example does not work.

CLAassistant commented 5 years ago

CLA assistant check
All committers have signed the CLA.

bigopon commented 5 years ago

@tebruno99 awesome 👍 @EisenbergEffect

3cp commented 5 years ago

There is import 'bootstrap/dist/css/bootstrap.css'; in main.js. The one in app.html <require from="bootstrap/css/bootstrap.css"></require> should be removed totally.

FYI, both <require from="bootstrap/css/bootstrap.css"></require> and <require from="bootstrap/dist/css/bootstrap.css"></require> should work without any problem, our aurelia-webpack-plugin supports that.

I guess the conflict with main.js (it is using the path with dist/) is the cause of the failure. It confused webpack tracer. Removing the require tag from app.html should fix this issue.

tebruno99 commented 5 years ago

I tested your suggestion and it worked as well. I had no way to know that, thanks! Pull request updated with the suggested fix.

3cp commented 5 years ago

You are welcome. The tutorial was first built for jspm(or requirejs I don't remember) setup, then converted to webpack. That's where the duplicated css imports came from.

EisenbergEffect commented 5 years ago

Thanks for working through this together and getting to the proper fix 😄