search

aurelia / documentation

The documentation for Aurelia.
MIT License
105 stars 111 forks source link

doc(store): remove outdated instruction for aurelia-cli #409

Closed 3cp closed 5 years ago

3cp commented 5 years ago

@zewa666 can you have a look? I remove the mention of rxjs-compat because the rxjs migration guide covered that, but I have no idea how to use rxjs-compat even after reading the migration guide.

The guide mentioned npm install rxjs@6 rxjs-compat@6 --save but has no code to import 'rxjs-compat';. How does it work?

3cp commented 5 years ago

@EisenbergEffect @zewa666 while reading aurelia-store doc, I noticed the missing object.entries polyfill from aurelia-polyfills.

Since aurelia-store is an official offering from Aurelia, I think aurelia-polyfills should cover that polyfill to smooth user experience. In fact, that polyfill is tiny, about 10 lines. Let me know what you think, I can follow up with PRs to aurelia-polyfills and store documentation.

EisenbergEffect commented 5 years ago

@3cp I seem to have some trace of a memory about why we didn't include that polyfill. However, if @zewa666 thinks it would be a good idea, I'm game for it.

zewa666 commented 5 years ago

@eisenbergeffect here is the related PR for the polyfill with some discussion. https://github.com/aurelia/polyfills/pull/64 I've talked to @3cp and we'd favour to get it in

zewa666 commented 5 years ago

PR looks good, the compat approach is no longer needed. Thanks @3cp for the fix. @eisenbergeffect ready for merge