search

aurelia / documentation

The documentation for Aurelia.
MIT License
105 stars 111 forks source link

Vm to viewmodel #426

Closed baerrach closed 5 years ago

baerrach commented 5 years ago

I originally sent one through change VM to view-model. view-model is used 37 times across documentation, while ViewModel is used 13 times. Yet ViewModel is a better choice as that is what outside documentation refers to in Model-View-ViewModel and searching in the repository for view-model will not find code samples. Unifying to ViewModel makes more sense.

EisenbergEffect commented 5 years ago

This is awesome!

baerrach commented 5 years ago

@EisenbergEffect I have a question about view-model or ViewModel.

I like reading the lower case, kebab version. But everything on the web is ViewModel, which really means that view needs to turn into View as well.

I think VM to something else is a worthwhile change.

view-model to ViewModel is just for consistency sake and not as useful.

Do you have thoughts?

EisenbergEffect commented 5 years ago

Well, I Iike the changes you’ve made around ViewModel. However, I’m not sure if we need to change all instances of view to View throughout the docs. I could be convinced either way.

baerrach commented 5 years ago

Great, I think that answers my question.

view-model to ViewModel everywhere is a nice to have and I've got other things to work on.

Cheers.