search

aurelia / documentation

The documentation for Aurelia.
MIT License
105 stars 111 forks source link

Minor typo in Contact Manager tutorial #450

Open lion-200 opened 4 years ago

lion-200 commented 4 years ago

I'm submitting a minor typo in Contact Manager tutorial documentation

Current behavior: The file name needs to be created in section Adding Pub/Sub Messaging is called "message.ts" while further in the code of contact-detail.ts "messages" is being imported.

Expected/desired behavior: Minor change in the file name to be created. From "message.ts" to "messages.ts"

image

3cp commented 4 years ago

There is no problem for TypeScript to understand that import without extname .ts, same as babel has no problem to understand any import without extname .js.

If you saw some error in your app, either in editor or running app, let's know.

lion-200 commented 4 years ago

The problem is not the .ts or .js extension, but the name of the module trying to be loaded:

image

The name of the file must be with an "s" added or the imported module must be without the "s" in the end.

3cp commented 4 years ago

Oh, sorry, I miss read your issue. Send over a PR if you want to :)

lion-200 commented 4 years ago

No problem :) PR created ;) Thanks.