search

aurelia / documentation

The documentation for Aurelia.
MIT License
105 stars 110 forks source link

Add documentation for Docker builds #455

Closed shahabganji closed 5 years ago

shahabganji commented 5 years ago

In this PR, I am trying to add some documentation to indicate how it is possible to dockerize Aurelia application.

cc/ @EisenbergEffect

EisenbergEffect commented 5 years ago

Looking good. @shahabganji Let me know when it's set to go in and I'll get it merged, do an edit pass and then publish it to the site. Thanks for prioritizing documentation! It's a big deal for our community :)

PS Please don't use emoji in the docs. Our site generator doesn't support them at present 😢

shahabganji commented 5 years ago

@EisenbergEffect I just wanted to ping you to let you know this is done, if you think I should change something please let me know.

EisenbergEffect commented 5 years ago

Excellent. Thank you @shahabganji I'll try to review it this weekend. We've recently had a flurry of very exciting activity around Aurelia, so my backlog very quickly expanded. I may not get to it right away, but I'll try. If you don't see this get merged in the next day or two, feel free to bug me 😄

shahabganji commented 5 years ago

@EisenbergEffect I should have let you know earlier but I thought if I only remove the WIP you might have got notified so didn't want to double ping 😄

And good to hear about activities around Aurelia, do you think I could be of any help?

EisenbergEffect commented 5 years ago

Thanks for the offer @shahabganji Unfortunately, most of what has landed on my plate, only I can do. It's all good but just might delay a full review of this by a day or two.

EisenbergEffect commented 5 years ago

I had a few extra minutes between tasks, so I gave it a review and was able to merge. I'll also have our technical writer look at this. Thanks for working on our docker support and documenting it!