search

aurelia / documentation

The documentation for Aurelia.
MIT License
105 stars 111 forks source link

doc(contact-manager-tutorial): fix layout issue in bootstrap v4 #473

Closed 3cp closed 4 years ago

3cp commented 4 years ago

When this tutorial was upgraded from bootstrap v3 to v4, the layout is not quite right.

  1. the left contact list is only clickable on the text, not the whole item.
  2. the form layout is incorrect, leaving right side a blank gap.
  3. some font size is too big, might due to bootstrap changes. The updated code can be reviewed lively at https://gist.dumber.app/?gist=da1297fe5662ce31911cf5cb2bdce960 Also updated router config to use pushState.
EisenbergEffect commented 4 years ago

Any particular reason to also enable push state? I'm not opposed to it, just not sure if we need to add an explanation in the tutorial related to that.

3cp commented 4 years ago

I am not sure why it's not enabled in the tutorial, probably because it was created long ago.

The tutorial now uses aurelia-cli to build, the default webpack skeleton has proper <base href="/"> in the html head.

I think current users would expect a framework using push state. I will add some explanation.

3cp commented 4 years ago

dumber-gist embedded browser back/forward buttons only support pushState based routing, because it monkey-patches pushState and replaceState.

EisenbergEffect commented 4 years ago

Thanks!