aurelia / documentation

The documentation for Aurelia.
MIT License
105 stars 111 forks source link

Tutorial contains broken link to App Configuration and Startup #488

Closed Nallebeorn closed 1 year ago

Nallebeorn commented 1 year ago

I'm submitting a bug report

Current behavior:

Expected/desired behavior:

Interestingly, the repo seems to have the correct URL, as it was fixed in this PR: https://github.com/aurelia/documentation/pull/485

That PR was however merged one and a half years ago, so it doesn't seem right that this issue is still present on the live site.

3cp commented 1 year ago

There is some missed regeneration of our site for a while. I raised a PR to our private github pages repo to update all docs.

@bigopon we probably should open up https://github.com/aurelia/aurelia.github.io.

3cp commented 1 year ago

Published latest doc but found another issue.

The merged doc fix "../docs/..." did not work well, at least failed on Edge.

It should just use absolute path "/docs/..." as other pages use.

bigopon commented 1 year ago

@bigopon we probably should open up https://github.com/aurelia/aurelia.github.io.

You meant making it non-private? I can do that, though I'm not sure what sensitive information in the repo itself, or its history may be leaked, since I only took over from @EisenbergEffect

3cp commented 1 year ago

I will raise another PR for the site update.

3cp commented 1 year ago

Site is updated.