aurelia / framework

The Aurelia 1 framework entry point, bringing together all the required sub-modules of Aurelia.
MIT License
11.75k stars 625 forks source link

AureliaHUB leaks memory #800

Closed peteigel closed 7 years ago

peteigel commented 7 years ago

I'm submitting a bug report

Please tell us about your environment:

Current behavior: When navigating around AureliaHUB, memory usage appears to grow without clear bounds.

I wrote a script for the browser console to simulate navigating around in circles. In both Chrome and Firefox, I observed memory usage growing slowly.

Below is a screenshot of Chrome's Allocation Timeline profile: Chrome Allocation Timeline

And Before/After Heap Snapshots in Firefox: Before: 8.39MB FF Heap Before

After: 57.20MB FF Heap After

The after snapshot was taken after ~500 simulated mouse clicks. The navigations item were the first and only set I tried, I suspect this issue is site-wide.

Expected/desired behavior: Memory usage should not continue to grow when navigating to pages repeatedly.


The leaked objects appear to have the e prototype in the minified code. I believe they may be Binding objects, but I am not sure.

AshleyGrant commented 7 years ago

@EisenbergEffect this looks like it's a possible bug in the framework, not the HUB.

EisenbergEffect commented 7 years ago

To be honest, the HUB is a terrible piece of code. We're replacing it and the entire web site soon, hopefully in another month or so. The whole thing has been written from scratch: all new html, js and css. I'm closing for now. If we find a general memory leak, let's open that somewhere with a simple repro.

burnhamrobertp commented 7 years ago

....so are we expected to go out and find exactly where the resource leak is in the framework? I don't see any followup issue created to investigate this and @EisenbergEffect 's quick closure of this ticket mere hours after its opening leaves me uneasy that this isn't a priority for Aurelia. The scale we see this leak occurring at, its quickly becoming a huge issue for the b2b applications we're developing that (for the moment) use Aurelia.

AshleyGrant commented 7 years ago

@harkenn I believe that Rob is asking to have a separate issue filed for this with a simple repro of the leak. Probably something that uses one of the skeleton projects would work best.