aurelia / framework

The Aurelia 1 framework entry point, bringing together all the required sub-modules of Aurelia.
MIT License
11.76k stars 623 forks source link

Duplicate of aurelia-binding in webpack bundle #902

Closed searus closed 6 years ago

searus commented 6 years ago

Hi,

I experienced a strange issue yesterday when I updated an existing project to use Webpack 4. I started seeing duplicated custom elements rendered and could see no reason for it.

Eventually, I managed to track it down to 2 instances of aurelia-binding being included in my bundle. The second instance is included as an older version appears under node_modules/aurelia-templating-router/node_modules/aurelia-binding.

This confused me as I was not using the aurelia-router and the package was not included in my package.json. It appears as though aurelia-framework has a reference to aurelia-templating-router that may be including the package in the build: https://github.com/aurelia/framework/blob/3928b336e00937d9e33eb914d8a784759eeafd5b/dist/native-modules/aurelia-framework.js#L452

Please can you check this out and see if there's a problem?

Thanks

searus commented 6 years ago

Could this be related to #830 ??

searus commented 6 years ago

Here's a screen shot through dev tools to show the duplicate:

image

If I install aurelia-templating-router in my package then the problem goes away.

Alexander-Taran commented 6 years ago

Update aurelia packages.. This is resolved.

searus commented 6 years ago

@Alexander-Taran I am on the latest versions: "aurelia-bootstrapper": "2.3.0" "aurelia-framework": "1.3.0"

This happened in a project created from aurelia-cli@0.33.1 yesterday.

StrahilKazlachev commented 6 years ago

You sure you don't have a lock file?

searus commented 6 years ago

I think you're right... I was getting the wrong version from aurelia-dialog I believe. Thanks!

StrahilKazlachev commented 6 years ago

aurelia-dialog is still not updated, sorry. Will try this week.

searus commented 6 years ago

No need to apologise... you guys are great and I appreciate everything coming from the Aurelia team!!