Fix: missing resolvers when reloading a view

[rluba]

recreateView creates a new container but did not copy the resolvers from the old container. This caused local DI instances (eg. injected into the controller via NewInstance.of) to be missing.

This fixes aurelia/validation#469, at least the HMR issue described by @alexdresko.

Here's a concrete example using a state component (for routing) and it’s view:

Component

@inject(NewInstance.of(ValidationController))
export class EditState {
    constructor(validator) {
        this.validator = validator;
        }
…
}

View

<template>
    <input type="number" name="something" value.bind="something & validate">
</template>

This state initially loads correctly, but when modifying the view, ValidateBindingBehaviorBase throws because it can’t locate the ValidationController because the corresponding resolver is missing from the view’s new container that’s created by HMR.

I’m relatively new to Aurelia, so I don’t know if the resolvers were not copied on purpose. @EisenbergEffect probably knows whether this was intended or not. If the resolvers should not be copied, then we need a different way to keep local DI instances during HMR.

[rluba]

Is there any reason why this fix has been unmerged for almost a full year?

[EisenbergEffect]

@rluba Somehow this must have gone under the radar. I'm merging now and adding to my release task list for this week. Apologies!

[rluba]

@EisenbergEffect Much appreciated, thanks!