HTTPClient.delete(url) sends undefined in request body on IE11

aurelia / http-client

A simple, restful, message-based wrapper around XMLHttpRequest.

MIT License

62 stars 59 forks source link

HTTPClient.delete(url) sends undefined in request body on IE11 #127

Closed reinholdk closed 6 years ago

reinholdk commented 8 years ago

The delete method serializes the empty request content as undefined into the request body. This can cause a server to reject the request, if the server does not ignore the payload. The behavior of the server is in accordance to the HTTP/1.1 spec. (RFC 7231) which says:

A payload within a DELETE request message has no defined semantics; sending a payload body on a DELETE request might cause some existing implementations to reject the request.

EisenbergEffect commented 8 years ago

@reinholdk This seems like an excellent opportunity to send a PR to fix the issue. Any interest?

reinholdk commented 8 years ago

@EisenbergEffect sure, I can prepare a fix.

reinholdk commented 8 years ago

@EisenbergEffect have signed the CLA some days back, but still getting a 403 when trying to push may change. Any idea?

EisenbergEffect commented 8 years ago

You can't push a change to our repro. You need to submit a pull request. Then, we will review the change and merge.

Alexander-Taran commented 6 years ago

pull request merged can be closed?