search

aurelia / http-client

A simple, restful, message-based wrapper around XMLHttpRequest.
MIT License
62 stars 59 forks source link

fix(headers): #152 - Made header treatment case insensitive #153

Closed fragsalat closed 7 years ago

fragsalat commented 7 years ago

Regarding the issue #152 I made the Headers treatment to be case insensitive. I saw the Map class to fit as best for this use case but if you see a better solution tell me :)

@EisenbergEffect what do you say?

CLAassistant commented 7 years ago

CLA assistant check
All committers have signed the CLA.

fragsalat commented 7 years ago

Sry. Had to fix the username and email of the commit again -,-

EisenbergEffect commented 7 years ago

@bryanrsmith Any thoughts? Looks pretty straight forward to me.

fragsalat commented 7 years ago

@heruan I'll do tomorrow. Thx for that Info

bryanrsmith commented 7 years ago

lgtm. @fragsalat Just curious, why the switch to Map? I have no objection to using a Map, but it does look like the majority of the changes are related to the switch to map. I think the desired outcome could have been accomplished using the object as before with only a few lines changed.

fragsalat commented 7 years ago

@bryanrsmith You're right. It just came with testing different solutions for there performance. I gonna change it back to an Object.

EisenbergEffect commented 7 years ago

Thanks all!

fragsalat commented 7 years ago

Yeah. Thanks :)