search

aurelia / http-client

A simple, restful, message-based wrapper around XMLHttpRequest.
MIT License
62 stars 59 forks source link

Support traditional style when serializing params. #168

Closed jmvtrinidad closed 7 years ago

jmvtrinidad commented 7 years ago

Support for issue #160 and adding params and traditional to HttpClient.get method.

EisenbergEffect commented 7 years ago

@bryanrsmith Any chance you could review this?

EisenbergEffect commented 7 years ago

@jmvtrinidad I'd like to review this, but first, can you remove the changes to config.js and the dist folder from this PR? Thanks!

jmvtrinidad commented 7 years ago

Hi @EisenbergEffect , I think my commit has been rollback. Thank you.

EisenbergEffect commented 7 years ago

Excellent. This is much easier to review :) I'll take a look and see if we can get this in. Off the top of your head, does this create any breaking changes or backwards compat issues?

jmvtrinidad commented 7 years ago

based on the test it does not break any changes, as the additional parameters are only optional and have the default value just like before.