feat(type annotation): added type info

aurelia / http-client

A simple, restful, message-based wrapper around XMLHttpRequest.

MIT License

62 stars 59 forks source link

feat(type annotation): added type info #84

Closed louislewis2 closed 9 years ago

louislewis2 commented 9 years ago

This will improve the quality of the generated d.ts file and also improves readability of the modified classes by specifying the expected type of parameters in the contructor and also for certain return values.

louislewis2 commented 9 years ago

Hi @bryanrsmith thanks for the review & comments. I was intending on doing a bigger change in this repo, but thought I would start small to get a good handle on the process. For the private helper functions, I find value in having them typed as well, provides me and I am sure others with similar ide's a great design time experience.

EisenbergEffect commented 9 years ago

@louislewis2 Can you rebase on the master branch please? Thanks!

louislewis2 commented 9 years ago

I have rebased from master. Please check if everything is in order now.

EisenbergEffect commented 9 years ago

Thats the way to do it! Merging shortly.