search

aurelia / http-client

A simple, restful, message-based wrapper around XMLHttpRequest.
MIT License
62 stars 59 forks source link

Improves type information on HttpClient.configure. #98

Closed MicahZoltu closed 9 years ago

bryanrsmith commented 9 years ago

Thanks, @Zoltu. Would you mind updating the commit message to follow our contributing guidelines? Something like feat(http-client): improve type information on HttpClient.configure

migajek commented 9 years ago

this won't make much sense until #71 is resolved, till then we need to use "any" anyway to allow calling methods missing in .d.ts

bryanrsmith commented 9 years ago

I'm going to close this for now. @Zoltu If you wouldn't mind updating your commit message and reopening the PR I'd be happy to merge it.

MicahZoltu commented 9 years ago

Sorry this took so long to get to. It would be nice if the release notes were based on PR messages rather than commit notes. I often make small changes like this in the GitHub web UI and don't have the repo cloned locally. Since the GitHub UI doesn't allow for editing history, updating the commit message is a bit of a pain.