search

aurelia / i18n

A plugin that provides i18n support.
MIT License
93 stars 70 forks source link

error after updating aurelia mid-october 2015 #24

Closed stephenlautier closed 9 years ago

stephenlautier commented 9 years ago

Hi,

After updating Aurelia to latest (Mid-October 2015), I've been getting errors caused by unsubscribe, this is due to a breaking change in Aurelia as specified.

The EventAggregator now returns a subscription object from its subscribe method. The subscription has a dispose method to unsubscribe from the original event. http://blog.durandal.io/2015/10/13/aurelia-mid-october-2015-releases-performance-and-portable-javascript/

So any event aggregator subscription has to be disposed by this.subscription.dispose(); instead of this.subscription(); https://github.com/aurelia/i18n/blob/b3fdc4acdea1178ffb4e71c90ab1162a2e7fa2ec/src/t.js#L75

stephenlautier commented 9 years ago

Added fix @ https://github.com/aurelia/i18n/pull/25

zewa666 commented 9 years ago

this should be fixed now with the latest release. Once again also thanks for your help and reporting the issue :+1: If there are still any problems, we can reopen this issue