search

aurelia / i18n

A plugin that provides i18n support.
MIT License
93 stars 70 forks source link

doc(i18n-with-aurelia): remove unnecessary brace and fix indentation #262

Closed davidtimovski closed 6 years ago

davidtimovski commented 6 years ago

There was an extra brace }); at the bottom. It probably wasn't noticed because of the extra indentation.

CLAassistant commented 6 years ago

CLA assistant check
All committers have signed the CLA.

Alexander-Taran commented 6 years ago

Usually people don't like when you mess with their indentation (-:

davidtimovski commented 6 years ago

The rare case when personal indentation preferences actually lead to a bug. Don't wanna start a war :)

Alexander-Taran commented 6 years ago

Guess you just did (-:

zewa666 commented 6 years ago

oh this is very true, must have been a copy-paste mistake. @davidtimovski may I ask you to sign our CLA in order for me to merge your PR? Thanks for the contribution

davidtimovski commented 6 years ago

@zewa666 I signed it earlier today. Not sure if it's pending approval or something.

Alexander-Taran commented 6 years ago

You probably commited with another email if so, you can git commit --amend --author="Author Name <email@address.com>" and git push --force email should match the one used on giithub

davidtimovski commented 6 years ago

Hmmm. So earlier today I know I entered my full name, GitHub username, and GitHub email in some Google Docs file. Apparently that's not the agreement. I just clicked the CLAssistant comment here now and I think that did it.

zewa666 commented 6 years ago

Thanks