Update I18N documentation

aurelia / i18n

A plugin that provides i18n support.

MIT License

93 stars 70 forks source link

Update I18N documentation #275

Closed rluba closed 6 years ago

rluba commented 6 years ago

The section about using BaseI18N was outdated:

TCustomAttribute already observes language change events and updates itself.
Base18N does not respect t-params, causing incorrect translations.

See #273 for details.

zewa666 commented 6 years ago

I'm not sure whether it's good to simply remove the documentation about the BaseI18N class as it's currently in use. Instead we should show a deprecation notice and that this is going to be removed with the next major release.

rluba commented 6 years ago

I thought removing it is the better option since there’s no need to use it anymore (even in the current release) and using it leads to translation errors.

zewa666 commented 6 years ago

True, although in combination with what is mentioned here, it might not be that bad. Nevertheless would you mind just updating your PR with the above mentioned typo?