Re-add typings.json - Githubissues

joelowrance commented 5 years ago

npm typings install step was broken because this is missing

Started get build failures stating https://raw.githubusercontent.com/aurelia/i18n/master/typings.json responded with 404, expected it to equal 200

zewa666 commented 5 years ago

With the new structure the typings are located in dist/typings instead of dist. But why are you exactly needing a typings.json file? Most tools nowadays read the typings property from package.json

zewa666 commented 5 years ago

Btw rawgit is going to be deprecated by 2019

joelowrance commented 5 years ago

@zewa666

I'm not very strong on front end build magic, so forgive me if this doesn't make sense...

We have a project based on the Aurelia Typescript Skeleton project. The typings.json that came with that looks like this (many entries removed for brevity).

{
  "name": "aurelia-skeleton-navigation-typescript",
  "dependencies": {
    "aurelia-binding": "github:aurelia/binding",
    "aurelia-validation": "github:aurelia/validation",
    "aurelia-i18n": "github:aurelia/i18n"
  },
  "globalDependencies": {
    "moment": "registry:dt/moment#2.11.1+20161010105546"
  }
}

When we (or our build server) runs "npm intstall" the typings are installed. Until this morning that step was working well, but when the typings.json file disappeared, this stopped working.

Adding a commit hash to the dependency fixed the issue, but we'd like to make sure we are always pulling in the latest during our development cycle.

Just browsing through the other projects in the typings file, I see that typings.json is still in the root for them.

Edit: I am also able to get this work by using a full path. Please feel free to close this, but it was disheartening to see something that had been working for months just suddenly break.

"aurelia-i18n": "github:aurelia/i18n/dist/typings/aurelia-i18n.d.ts"

zewa666 commented 5 years ago

Oh I See, youre likely still using https://github.com/typings/typings for TypeScript definitions. I'm sorry for breaking your build havent thought thats in use anymore since its long time depricated in favor of the npm types scope.

If you could update the path in your PR I'll get this one merged since it does no harm in keeping it in.

Again sorry for the trouble it was causing you.

zewa666 commented 5 years ago

Btw the new master branch is on a breaking change major bump. Please take a look at the release notes. It would be great if you could give the Beta a spin. With regards to typings though I'd highly encourage to remove the entry for aurelia-i18n since this version is a TS rewrite and bring's its own typedefinitions.

PS if you need help ping me on gitter

joelowrance commented 5 years ago

PR updated. Thanks for the help in getting this added back in. I will give the beta a try as soon as I get a chance, but we're really only using it in a very limited way (2 or 3 key phrases that are customer specific).

zewa666 commented 5 years ago

Thx

aurelia / i18n

Re-add typings.json #287