aurelia / i18n

A plugin that provides i18n support.
MIT License
93 stars 70 forks source link

Sonatype reports vulnerabilities in i18next version used by aurelia-i18n #340

Closed adityazagade closed 3 years ago

adityazagade commented 3 years ago

Current behavior: Sonatype has reported security vulneribilities in i18next v14.1.1 sonatype-2020-0598 8.1 i18next : 14.1.1 sonatype-2020-0577 7.5 i18next : 14.1.1 sonatype-2021-0184 7.5 i18next : 14.1.1

CVSS scores of 8.1, 7.5 are high.

However using 19.8.5 by doing npm forced causes build to fail with the following error: /aurelia-i18n/dist/aurelia-i18n.d.ts(8,49): error TS2503: Cannot find namespace 'i18next'. /aurelia-i18n/dist/aurelia-i18n.d.ts(12,49): error TS2503: Cannot find namespace 'i18next'. /aurelia-i18n/dist/aurelia-i18n.d.ts(29,43): error TS2503: Cannot find namespace 'i18next'. /aurelia-i18n/dist/aurelia-i18n.d.ts(31,37): error TS2503: Cannot find namespace 'i18next'. /aurelia-i18n/dist/aurelia-i18n.d.ts(36,39): error TS2503: Cannot find namespace 'i18next'. /aurelia-i18n/dist/aurelia-i18n.d.ts(173,31): error TS2503: Cannot find namespace 'i18next'. TypeScript: 6 semantic errors

I think that the changes made i18next 19.0.0 have cause these breaking changes. Pls look at their change.md file for more details.

adityazagade commented 3 years ago

By changing the import statement in aurelia-i18n.d.ts, to

import * as i18next from "i18next";

I was able to build.

adityazagade commented 3 years ago

@zewa666 @Sayan751 @krisha2

adubois1337 commented 3 years ago

Is there any plan to roll this package upgrade into a future release?