search

aurelia / loader-webpack

An implementation of Aurelia's loader interface to enable webpack.
MIT License
26 stars 10 forks source link

refactor(loader-webpack): refactored aysnc await code to use promises #34

Open suneelv opened 7 years ago

suneelv commented 7 years ago

In response to https://github.com/aurelia/skeleton-navigation/issues/821 FYI This didn't prevent the out of stack space error in ie11

CLAassistant commented 7 years ago

CLA assistant check
All committers have signed the CLA.

suneelv commented 7 years ago

@jods4 Thanks for the comments. I am new to this. I will update the pull request with changes.

suneelv commented 7 years ago

@jods4 Yes I am always returning promises from all the old async methods. I am not really familiar with what loader-webpack is doing. So it would be better if you can just skim through it once again.

jods4 commented 7 years ago

Not requiring the async downlevel helpers from TS will make the code smaller... but sadly the stack overflow is still not fixed :(

EisenbergEffect commented 7 years ago

@niieani Is this good to merge then?

niieani commented 7 years ago

@EisenbergEffect It would be good to test against the skeleton (I haven't) but otherwise looks good. Perhaps we can release tagged as beta or RC first, and if no issues show, re-release as final.

EisenbergEffect commented 6 years ago

@jods4 Have we tested this? What should we do with this PR?

jods4 commented 6 years ago

@EisenbergEffect The runtime loader is really @niieani's work. I have reviewed the PR and it looks good, I haven't tested it, though.

niieani commented 6 years ago

Yes, looks good as @jods4 said, but I haven't tested either.

EisenbergEffect commented 6 years ago

Has anyone tested this out yet?