aurelia / loader-webpack

An implementation of Aurelia's loader interface to enable webpack.
MIT License
26 stars 10 forks source link

fix(index): ensure using the `raw` loader from the `css-resource-plugin` #6

Closed stoffeastrom closed 8 years ago

EisenbergEffect commented 8 years ago

@stoffeastrom I've been going back over things. It seems this is still a valid fix right? Can you confirm? If so, I can merge immediately. Let me know.

stoffeastrom commented 8 years ago

I've only tested 'local' require and haven't gotten an 'external' require to work yet.. I think it needs some more investigation so hold back on your merge finger ;-). I still think it's valid though

Sent from my iPhone

On 13 apr. 2016, at 15:07, Rob Eisenberg notifications@github.com wrote:

@stoffeastrom I've been going back over things. It seems this is still a valid fix right? Can you confirm? If so, I can merge immediately. Let me know.

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub

EisenbergEffect commented 8 years ago

Got it. I'll wait to hear from you. Thanks for investigating!

stoffeastrom commented 8 years ago

Unfortunately I thought it worked but after some more investigation it turned out that webpack added the css :pensive: I'm not sure this is possible and it's this part that I can't get to work

require.ensure([], function (require) {
  var result = require('aurelia-loader-context/' + path);
  if (typeof result === 'function') {
    result(function (res) {
      return resolve(res);
    });
  } else {
    resolve(result);
  }
});
EisenbergEffect commented 8 years ago

@stoffeastrom Should I close this out? Or do you have a solution or update to the PR?

stoffeastrom commented 8 years ago

No this should be closed