search

aurelia / loader-webpack

An implementation of Aurelia's loader interface to enable webpack.
MIT License
26 stars 10 forks source link

Remove /*# sourceURL= */ from css-loader content #62

Closed josundt closed 2 years ago

josundt commented 2 years ago

Fixes #61.

Waiting for a package release. I guess a release of aurelia-webpack-plugin might also be desirable to update the version constraint for aurelia-loader-webpack.

josundt commented 2 years ago

It looks like the circleci build failed. Since the build pipeline uses npm install instead of npm ci, I guess a newer version of the "@rollup/plugin-typescript": "^8.2.3" package was used compared to the previous build, and this new version seems to expect tslib as a peer dependency.

bigopon commented 2 years ago

probably it shouldn't be npm i. We can lock the version and do npm ci in the pipeline. Can you also push that change into this PR? For the release, it'll probably take another few hours. I've got a few things on my plate at the moment.

josundt commented 2 years ago

@bigopon I can do that. I also found that package-lock.json references aurelia-path@1.1.5. This package reports a npm audit vulnerability which has been mitigated in 1.1.7 (latest).

Running npm audit fix mitigates this, and updates package-lock.json (only changes reference for aurelia-path). Is it OK to also include this?

bigopon commented 2 years ago

Hmm, that sounds like a bit too much to ask a contributor. Maybe let me take care of it, I'll be also updating a few other stuff in this repo. Thanks for pointing that out 👍

josundt commented 2 years ago

That's OK 🙂. I've updated the circleci yaml file👍

josundt commented 2 years ago

Seems it still did not fix the build issue though. Not sure why... npm run build works fine on my machine after running npm ci...

josundt commented 2 years ago

@bigopon circleci build uses Node 12.x.

I got the same error on my machine when running npm ci + npm run build on Node 12 (12.22.12). But with Node LTS (16.17.0), everything works fine.

Can I change the circleci yaml file to image: circleci/node:16 instead of image: circleci/node:12?

bigopon commented 2 years ago

@josundt just got back to this, and I took over to get it out faster, hope you dont mind. I've changed node to 16 for your last question. Thanks for the analysis and the work.

josundt commented 2 years ago

@bigopon Just tested the new release in our app, and it fixes the SCSS => CSS source map problem as expected 👍 Thanks for your quick support once again! 🙂