search

aurelia / loader-webpack

An implementation of Aurelia's loader interface to enable webpack.
MIT License
26 stars 10 forks source link

ensureOriginOnExports modification for target test #7

Closed stphdenis closed 8 years ago

stphdenis commented 8 years ago

Having done a native loader for Meteor 1.3 and making changes following yours, should it be possible to make this little change ? If somebody is interested, it is there : https://github.com/stphdenis/aurelia-loader-meteor

EisenbergEffect commented 8 years ago

We can easily merge this. Can you describe the scenario where this is needed?

stphdenis commented 8 years ago

It's not directly for loader-webpack but for the new loader for Meteor 1.3 witch uses 98% of your code. When loading in Meteor with aurelia-loader-meteor, it seems to not have a target all the time. I have not yet found the reason but it works fine.

2016-04-15 17:52 GMT+00:00 Rob Eisenberg notifications@github.com:

We can easily merge this. Can you describe the scenario where this is needed?

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/aurelia/loader-webpack/pull/7#issuecomment-210564052

stphdenis commented 8 years ago

Don't merge this request. I'm sorry for the time I made you spend. The problem was how find the good way to require some modules like aurelia-templating-resources/sanitize-html.