Closed izderadicka closed 8 years ago
@izderadicka Thank you. In order to accept this, we would need you to do two things. First, please sign the CLA. There is a link in the checks section of this PR. Second, please remove all changes in the dist
folder since those are generated by us during the release process.
OK will do, I've signed CLA just now (I guess you should update link to CLA CONTRIBUTING.md because it led me to other form - on google docs, which I accepted also) - hope hope now its's ok. I will remove changes in dist. However I noticed that this change in dist/system/index.js
- if (_key !== "default" && key !== "__esModule")
_exportObj[_key] = _aureliaMetadata[_key];
+ if (_key !== "default" && _key !== "__esModule")
_exportObj[_key] = _aureliaMetadata[_key];
the original file was reference to key in second part of if condition- however variable seem to be _key - are you sure original version was correct?
I.
On 2.10.2016 16:14, Rob Eisenberg wrote:
@izderadicka https://github.com/izderadicka Thank you. In order to accept this, we would need you to do two things. First, please sign the CLA. There is a link in the checks section of this PR. Second, please remove all changes in the |dist| folder since those are generated by us during the release process.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/aurelia/metadata/pull/45#issuecomment-250973290, or mute the thread https://github.com/notifications/unsubscribe-auth/ACFaBYNZ0G6Mz9j1SH7SZY52WYsekunuks5qv7xJgaJpZM4KL_4Z.
Please ping this issue once the dist folder contents are removed from the commit.
@izderadicka you forgot to: @EisenbergEffect ping
@EisenbergEffect ping Hope PR is fine now @doktordirk thanks for reminder
Looks good. Thanks!
Fixing issue #41 Added type check to Origin.get module search loop plus couple of tests.