search

aurelia / metadata

Utilities for reading and writing the metadata of JavaScript functions.
MIT License
28 stars 33 forks source link

Specify aurelia-pal version in typings dependency. #49

Closed jp7677 closed 6 years ago

jp7677 commented 7 years ago

Hi there,

When installing the TypeScript typings for a project that uses aurelia-metadata with typings install you will see the following output:

typings WARN badlocation "github:aurelia/pal" is mutable and may change, consider specifying a commit hash
├─┬ aurelia-metadata
│ └── aurelia-pal

This happens because https://github.com/aurelia/metadata/blob/master/typings.json does not specifies a version. Wouldn't it be better if the aurelia-pal dependency was specified as e.g. "aurelia-pal": "github:aurelia/pal#1.0.0" instead of just "aurelia-pal": "github:aurelia/pal". That would resolve the imho justified warning.

PS: The same applies to https://github.com/aurelia/pal-browser/blob/master/typings.json.

loku02 commented 7 years ago

Any progress here? This doesn't change for almost a year now.

jp7677 commented 6 years ago

I had moved from jspm/typings to webpack some time ago. Closing this since this is no longer an issue for me.