search

aurelia / new

The Aurelia 2 scaffolding repo used by our tools to setup new projects.
MIT License
35 stars 18 forks source link

Properly support silent mode #82

Closed ghost closed 2 years ago

ghost commented 2 years ago

https://github.com/aurelia/new/blob/5842dceb1b9ee3376986080ff0870d48797d1a3e/questions.js#L62

There is no way to disable this option when passing -s to makes.

See https://makes.js.org/silent-mode#properly-support-silent-mode

Suggest providing a no-e2e value to pass to -s.

3cp commented 2 years ago

What do you mean? If you don't put playwright in -s, it will skip playwright.

The doc tells there is complication when no-value is not first default choice, but that's not the use case here.

typecampo commented 2 years ago

Ah yes I think you are correct. I was thinking it was adding it because the e2e directory gets added either way.

3cp commented 2 years ago

Thx, I saw that now. That's a missing condition on that file, I will fix it now.