search

aurelia / polyfills

The minimal set of polyfills needed to run Aurelia.
MIT License
26 stars 27 forks source link

Update string,js #27

Closed FlorianGrimm closed 8 years ago

FlorianGrimm commented 8 years ago

running on a page that includes MicrosoftAjaxCore - results in a bad polyfill since implemented it without the position parameter for startsWith and endsWith. The problem is shown here https://jsfiddle.net/floriangrimm/nee9b6kh/2/

EisenbergEffect commented 8 years ago

@FlorianGrimm Thank you for contributing this pull request! We're truly excited and honored to have you as a member of our community. We look forward to working together with you to further build the Aurelia platform.

We noticed that you haven't yet signed our CLA. We would appreciate it if you would consider doing that for us. Before signing, please take a few minutes to read our contributing guidelines. These guidelines will help get you up to speed on how our community likes to operate and how the pull request process works. Once you have read that, assuming you are in agreement, simply sign our online CLA.

After you've signed, please ping this issue to let us know and we'll get your improvements merged in.

Thank you again! The Aurelia Team

FlorianGrimm commented 8 years ago

Hello Rob

I signed the CLA. Sorry I'm new to git.So I'll hoe I done it right until now...So is this the ping? In https://jsfiddle.net/floriangrimm/nee9b6kh/2/ iI'll try to explain the bug - not yours - but it broke "your" polyfill.

txs flori

2016-06-09 0:57 GMT+02:00 Rob Eisenberg notifications@github.com:

@FlorianGrimm https://github.com/FlorianGrimm Thank you for contributing this pull request! We're truly excited and honored to have you as a member of our community. We look forward to working together with you to further build the Aurelia platform.

We noticed that you haven't yet signed our CLA. We would appreciate it if you would consider doing that for us. Before signing, please take a few minutes to read our contributing guidelines https://github.com/DurandalProject/about/blob/master/CONTRIBUTING.md. These guidelines will help get you up to speed on how our community likes to operate and how the pull request process works. Once you have read that, assuming you are in agreement, simply sign our online CLA https://docs.google.com/forms/d/1Npd68d32UDUKUYuCDDrW0VN5Lv8p-a6Ziaa2JFKp6Cg/viewform?c=0&w=1 .

After you've signed, please ping this issue to let us know and we'll get your improvements merged in.

Thank you again! The Aurelia Team

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/aurelia/polyfills/pull/27#issuecomment-224756208, or mute the thread https://github.com/notifications/unsubscribe/ACeTiqQ65SeoVAz6E08M3meXKZEgnjgNks5qJ0jWgaJpZM4Irj5R .

EisenbergEffect commented 8 years ago

Thanks!