aurelia / polyfills

The minimal set of polyfills needed to run Aurelia.
MIT License
26 stars 27 forks source link

No Reflect.ownKeys polyfill #28

Closed graemechristie closed 8 years ago

graemechristie commented 8 years ago

Current Reflect polyfill does not contain the ownKeys method.

I'm currently using the martingust/aurelia-repeat-strategies plugin (https://github.com/martingust/aurelia-repeat-strategies), which makes use of Reflect.ownKeys

Either I can submit a PR for the ownKeys polyfill to this repo (which is simply)

if (typeof Reflect.ownKeys !== 'function')
    Reflect.ownKeys = function (o) {
    return (Object.getOwnPropertyNames(o).concat(Object.getOwnPropertySymbols(o))));
}

Or I can submit a PR to martin's repo replacing his call to ownKeys with the above.

Do you have any preference ?

EisenbergEffect commented 8 years ago

Please submit a PR to this repo. Thanks for catching this!

graemechristie commented 8 years ago

No worries, PR inbound !