search

aurelia / polyfills

The minimal set of polyfills needed to run Aurelia.
MIT License
26 stars 27 forks source link

fix(symbols): check that descriptors is an object #47

Closed slackboxster closed 7 years ago

slackboxster commented 7 years ago

In IE, createWithSymbols fails if descriptors is undefined, giving the following error: "Object.getOwnPropertyNames: argument is not an Object" This makes sure the item is an object before continuing.

I've not been able to run the test suite on this yet. (Running out of time for the day, so I figured even if I have to come back later and fix it up, this could benefit people in between time). This is my first time contributing to an aurelia repo, so I'm unfamiliar with the build process and that kind of thing.

CLAassistant commented 7 years ago

CLA assistant check
All committers have signed the CLA.

slackboxster commented 7 years ago

Just looked at the test suite this morning, doesn't appear to have any tests, but I have gone ahead and built the changes. Let me know if there is anything else I need to do to properly contribute. :)

slackboxster commented 7 years ago

This solves #48

EisenbergEffect commented 7 years ago

@slackboxster Can you remove all changes in the dist folder from thsi PR? That will be generated when we build the code for release. Thanks!

slackboxster commented 7 years ago

@EisenbergEffect That makes total sense. I just removed the dist changes.

EisenbergEffect commented 7 years ago

Thanks!