aurelia / polyfills

The minimal set of polyfills needed to run Aurelia.
MIT License
26 stars 27 forks source link

propertyIsEnumerable null reference exception in IE 11 #50

Closed sludemann closed 7 years ago

sludemann commented 7 years ago

I'm submitting a bug report

Please tell us about your environment:

Current behavior: Using ag-grid we're consistently getting the following exception in IE 11 when onGetRows fires: image

Expected/desired behavior: No null reference exception appears.

In symbol.js change propertyIsEnumberable to this:

propertyIsEnumerable = function propertyIsEnumerable(key) {
      var uid = '' + key;
      return onlySymbols(uid) ? (
        hOP.call(this, uid) &&
        this[internalSymbol] &&
        this[internalSymbol]['@@' + uid]
      ) : pIE.call(this, key);
    }

I'd be happy to submit the PR, but am unfamiliar with your process.

EisenbergEffect commented 7 years ago

We welcome your PR. Don't worry about the process too much for the first time. You'll be asked to sign the CLA and we may want to edit the commit title. We can walk you through that after you submit, if needed. Thanks!

tborres commented 7 years ago

This fixes our issue with the usage of Symbol in IE11, and appears to be a pretty straightforward null check. What steps are needed to get this merged in? It would be great to get this in the next version as I'm currently hotfixing in the node_modules, but I know that's eventually going to burn me (is that why it's called a hotfix?)

EisenbergEffect commented 7 years ago

Merged fix. Releasing in a few minutes.