Closed sludemann closed 7 years ago
We welcome your PR. Don't worry about the process too much for the first time. You'll be asked to sign the CLA and we may want to edit the commit title. We can walk you through that after you submit, if needed. Thanks!
This fixes our issue with the usage of Symbol
in IE11, and appears to be a pretty straightforward null check. What steps are needed to get this merged in? It would be great to get this in the next version as I'm currently hotfixing in the node_modules, but I know that's eventually going to burn me (is that why it's called a hotfix?)
Merged fix. Releasing in a few minutes.
I'm submitting a bug report
Please tell us about your environment:
Operating System: Windows 10
Node Version: 6.3.1
NPM Version: 3.10.3
JSPM OR Webpack AND Version webpack 2.2.1
Browser: IE 11
Language: ESNext
Current behavior: Using
ag-grid
we're consistently getting the following exception in IE 11 when onGetRows fires:Expected/desired behavior: No null reference exception appears.
In
symbol.js
change propertyIsEnumberable to this:I'd be happy to submit the PR, but am unfamiliar with your process.