Child router parameters in route with special characters behavior is unpredictable

[MT-PL-SWF-Dev]

I'm submitting a bug report

• Library Version: 1.0.6

Please tell us about your environment:

• Operating System: Windows 7

• Node Version: 5.0.0

• NPM Version: 3.3.8

• JSPM OR Webpack AND Version JSPM 0.16.42

• Browser: Chrome 53.0.2785.143 m
• Language: TypeScript 1.8

Current behavior: When using child routes with string parameters, uri resolving crashes when using special characters encoded in %XX format. E.g. route "#/main/child/%25" throws "URIError: URI malformed" thrown from RouteRecognizer.recognize() function line that uses decodeUri() function. Another special characters problem occurs randomly. E.g. route "#/main/child/fsd%40%2135%2A%28%29" navigates for the first time. When I try to navigate to exactly same location router throws " Error: Route not found".

Issue reproducted in Gist: https://gist.run/?id=2e0ff35d2e08641448e536d639e31a12

Expected/desired behavior: I'd like to use route parameter for search string, which is robust and as bulletproof as possible.

• What is the motivation / use case for changing the behavior? We are moving in our application to child routers in every view-models flow, and this is really serious for robustness of our app.

[MT-PL-SWF-Dev]

I have found anohter clue in this case. https://github.com/aurelia/router/blob/master/src/navigation-instruction.js#L175 It is run after child-router navigation. With % coded characters method "encodeURI" parse them and change e.g. %25 to %2525. It breaks child router by setting baseUrl to "".

[bigopon]

This is an issue with encodeURI and decodeURI API pair. They are meant to be used on full URI while in the router, we typically supplied the fragment, with query string/hash only. Could simply be fixed by changing encodeURI -> encodeURIComponent and decodeURI -> decodeURIComponent

@EisenbergEffect @davismj @fkleuver @jwx

[bigopon]

Hmm, it was a wrong analysis. Please ignore

[mjpearse]

Ran into what I think was this issue today with a string parameter going through the router. I didn't want to change it to a setting on the route as I wanted the user to be able to refresh the page on the other side.

My workaround was to encode the string as a base64 url encoded string rather than the usual encodeURIComponent (which was not working).