refactor(all): better interfaces, add router event export, more tests

aurelia / router

A powerful client-side router.

MIT License

120 stars 115 forks source link

refactor(all): better interfaces, add router event export, more tests #632

Closed bigopon closed 5 years ago

bigopon commented 5 years ago

This is now ready for review.

refactor to TS
ensure compat with latest release
add export RouterEvent for better typings/hooks
include fix #619
add more unit & integration tests

bigopon commented 5 years ago

For comparison, typings is based on 1.5.0 release (same for 1.6) at https://github.com/aurelia/router/blob/2a8a16622dc162c9bd24028a76420692f2a0882a/dist/aurelia-router.d.ts

bigopon commented 5 years ago

The latest commits https://github.com/aurelia/router/pull/632/files/26facc5f83fd7bb48da8e5015efb943e913c21f7..7d3ee63e77d585f7964ea6706163e1cd2dff7691 will export a few critical information related to router event enum and pipeline slot name enum, along with some comments for better understanding & usage

EisenbergEffect commented 5 years ago

@bigopon Is this ready?

bigopon commented 5 years ago

@EisenbergEffect yes it is ready. Everything has been reverted to internak refactoring instead of aiming for a 2.0 beta. Its a big refactoring so if needed, we can do a RC release

EisenbergEffect commented 5 years ago

@bigopon What is the release process for this library now? Just build and release from master? After this next release, will we be able to use the develop branch and align this process with the other updated repos?