aurelia / skeleton-navigation

Starter kits for building a standard navigation-style app with Aurelia.
Creative Commons Zero v1.0 Universal
732 stars 512 forks source link

TypeScript Code Coverage Task? #278

Closed Vheissu closed 2 years ago

Vheissu commented 8 years ago

Are there any plans to implement code coverage in the Aurelia TypeScript Skeleton like there is in the standard ES Skeleton? I ask because there is the isparta dependency in the package,json, but it is not being used. I would love to implement code coverage into my app, but not sure where TypeScript falls into this. I know testing was a pain to get working in the first place.

bfil commented 8 years ago

Has this actually been implemented in the TypeScript skeleton?

niieani commented 8 years ago

Yes, in both the Webpack skeletons. There's a pull request open regarding JSPM. On Fri, 24 Jun 2016 at 09:23, Bruno Filippone notifications@github.com wrote:

Has this been actually implemented in the TypeScript skeleton?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/aurelia/skeleton-navigation/issues/278#issuecomment-228275586, or mute the thread https://github.com/notifications/unsubscribe/AAiZDdTPH9d9l7apJ5_34dCAsU-p0FeOks5qO4XXgaJpZM4HO3ab .

bfil commented 8 years ago

@niieani looks like the PR is for esnext not typescript

AshleyGrant commented 8 years ago

I'm gonna look in to this today

Vheissu commented 8 years ago

@AshleyGrant I'll talk to you in the Gitter chat, but I have some work here which might help adding in coverage to the Karma testing.

Roustalski commented 8 years ago

Hey guys. Any headway here? Is there a branch somewhere that might have some work completed already that we can leech off of?

niieani commented 8 years ago

There's a discussion here, re. the parallel ESNext support: https://github.com/aurelia/skeleton-navigation/pull/519. We're open to pull requests for TS support, I've explained how it could be implemented in the discussion of the above pull (istanbul-remap).

Roustalski commented 8 years ago

I was able to get coverage working of my typescript files using the Aurelia CLI, but have run into an issue: http://stackoverflow.com/questions/39650904/how-do-i-get-the-aurelia-cli-to-provide-a-stack-trace-on-a-gulp-plugin-error

bfil commented 8 years ago

@Roustalski I've tried to clone your repo but it spits out an empty coverage for me..

It seems like karma-systemjs complicates things quite a bit, and I'm unable to get the coverage working in any way using it together with other karma plugins such as karma-coverage and karma-remap-istanbul.

The ESNext skeleton uses karma-jspm, is this supposed to use that instead?

@niieani can you elaborate on how you would plan to use gulp-istanbul?

Alexander-Taran commented 6 years ago

Stale since 2016

mttmccb commented 6 years ago

@Alexander-Taran I've tried a few times to get this working with my project and failed, last time I got an error similar to this repro.

Somewhat related from the CLI repo.

Alexander-Taran commented 6 years ago

Thanks @mttmccb

chrsmrtn- commented 6 years ago

I too have run into this issue when updating from 0.33.1 to 0.35.1. I use typescript as well