Question: require attribute on element

[4nderss]

I see you have the following default rule:

Require
ensure require elments have a 'from' attribute

I would like to configure so that this:

 tag: "button",
            attr: /^type$/,
            is: /^button$|^submit$|^reset$|^menu$/,
            msg: "button type invalid"

includes to check that there is a type tag present on each element.

Background: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/button

Button uses "submit" as the default value for type. This causes some unexpected behavior when no type is specified and user presses enter inside a form. Browser will try and find the submit button and "click" it. If there is a button without type present the wrong button will be "clicked".

We want to avoid this by sanity checking our html for this kind of thing.

Is this possible?

[MeirionHughes]

Not currently; could done by adding a "required" boolean option, then check to make sure the the element has that attribute.

Been swamped with some work code I need to get done; but I will try to get a release out on the weekend.

[MeirionHughes]

bolted on functionality for this.

see:

https://github.com/MeirionHughes/aurelia-template-lint/blob/b8fe917b6ce7feabfa1fc03c2325ad1046121d06/source/config.ts#L49

https://github.com/MeirionHughes/aurelia-template-lint/blob/b8fe917b6ce7feabfa1fc03c2325ad1046121d06/spec/required-attr.spec.ts

published: 0.9.22

[MeirionHughes]

Rolled back the config on this so its not on by default (until next minor version) ; you can add it on by setting the config:

config.requiredAttribute = [{
    tag: /^button$/,
    attr: /^type$/,
    msg: "buttons without a type have irregular behavour"
}];