search

aurelia / template-lint

Sanity check of Aurelia-flavor template HTML
Apache License 2.0
56 stars 17 forks source link

npm dependency on gulp should be a devDependency #177

Closed AdamWillden closed 3 years ago

AdamWillden commented 6 years ago

Hi @MeirionHughes ,

I've just gone through the process of upgrading to gulp4 and saw the usual gulp3 warnings:

npm WARN deprecated graceful-fs@1.2.3: graceful-fs v3.0.0 and before will fail on node releases >= v7.0. Please update to graceful-fs@^4.0.0 as soon as possible. Use 'npm ls graceful-fs' to find it in the tree.

I ran the specified command to find gulp-aurelia-template-lint holds the dependency to gulp3, however from what I can tell from your code it should only be a dev dependency not a run time dependency, right?

AdamWillden commented 6 years ago

@MeirionHughes just an FYI this is now a bigger issue as there are knock on effects with the low versions (vinyl, depreciated gulp-utils) that gulp3 uses. I'm having to remove this from my project to allow my builds to work again. I can see you've not worked on this for a while so with anticipation this won't be fixed soon I'm sad to have to remove such a useful tool.

AdamWillden commented 6 years ago

Ah, just noticed that gulp-utils is a direct dependency because of gutils.log which can be replaced with fancy-log as per this official blog post.

AdamWillden commented 3 years ago

Closing, seems dead, cleaning up my old issues