search

aurelia / templating-binding

An implementation of the templating engine's Binding Language abstraction which uses a pluggable command syntax.
MIT License
32 stars 26 forks source link

fix(SyntaxInterpreter): bind and oneTime defaultBindingMode #116

Closed bigopon closed 7 years ago

bigopon commented 7 years ago

fix aurelia/binding#598

I was trying to use only undefined

info.defaultBindingMode === undefined
        ? this.determineDefaultBindingMode(element, info.attrName, context)
        : info.defaultBindingMode,

but then it breaks test in option-binding.spec

so I had to added null:

info.defaultBindingMode === undefined || info.defaultBindingMode === null
        ? this.determineDefaultBindingMode(element, info.attrName, context)
        : info.defaultBindingMode,

@jdanyow

jdanyow commented 7 years ago

Another nice fix! Thank you @bigopon! Keep up the good work :beers: :dancing_women:

bigopon commented 7 years ago

Thanks!! 😄 🍻

One last thing, I think we should also close this aurelia/binding#609 👍