search

aurelia / templating-binding

An implementation of the templating engine's Binding Language abstraction which uses a pluggable command syntax.
MIT License
32 stars 26 forks source link

chore(templating-binding): make class es6 #60

Closed Alxandr closed 9 years ago

Alxandr commented 9 years ago

This allows all of babels transforms to run on the class, as well as discovery by the dts generator.

EisenbergEffect commented 9 years ago

Good call. I'll get it in soon.

EisenbergEffect commented 9 years ago

@Alxandr I can't accept this as the moment. It breaks the build. This is causing some sort of error with the babel-dts-generator I believe. Can you look into that? I receive errors when running gulp build.

Alxandr commented 9 years ago

Problem is. I receive errors from building the master branch before making a single change. It's probably true that babel-dts-generator doesn't support [foo] inside classes, which I can likely fix without too much hassle though.

Alxandr commented 9 years ago

@EisenbergEffect The issue should be resolved now (https://github.com/YoloDev/babel-dts-generator/blob/master/spec/class-method.src.js#L8). Would you mind retrying your build (after updating babel-dts-generator)?

EisenbergEffect commented 9 years ago

@Alxandr First issue down, now we've got another one. When I run the docs generation task (based on TypeDoc) I get the error "A computed property name in an ambient context must directly refer to a built-in symbol." Any idea what that issue is there?

EisenbergEffect commented 9 years ago

It seems to work fine on the TypeScript playground...

Alxandr commented 9 years ago

Yes. It's probably not a TypeScript problem.

On Mon, Oct 5, 2015, 15:39 Rob Eisenberg notifications@github.com wrote:

It seems to work fine on the TypeScript playground...

— Reply to this email directly or view it on GitHub https://github.com/aurelia/templating-binding/pull/60#issuecomment-145530472 .

Alxandr

EisenbergEffect commented 9 years ago

The error message is originating the the TS compiler I believe though...a quick google search located the message in the TS source. Maybe it's a version thing...

EisenbergEffect commented 9 years ago

Nope, the problem is TypeScript. It just only throws the error inside a d.ts file. I'll report the bug to them and see if they can resolve it. Until then, we'll have to wait on this.

EisenbergEffect commented 9 years ago

@Alxandr Even thought the class members are declared without brackets, the resulting d.ts files contains brackets in the class definition. It's the brackets, within that particular context, that cause the TS compiler to fail. Would it be possible to update the d.ts generator plugin to not emit the brackets? That should fix the problem. The result should look something like this:

  export class SyntaxInterpreter {
    static inject(): any;
    constructor(parser: any, observerLocator: any, eventManager: any);
    interpret(resources: any, element: any, info: any, existingInstruction: any): any;
    handleUnknownCommand(resources: any, element: any, info: any, existingInstruction: any): any;
    determineDefaultBindingMode(element: any, attrName: any): any;
    bind(resources: any, element: any, info: any, existingInstruction: any): any;
    trigger(resources: any, element: any, info: any): any;
    delegate(resources: any, element: any, info: any): any;
    call(resources: any, element: any, info: any, existingInstruction: any): any;
    options(resources: any, element: any, info: any, existingInstruction: any): any;
    'for'(resources: any, element: any, info: any, existingInstruction: any): any;
    'two-way'(resources: any, element: any, info: any, existingInstruction: any): any;
    'one-way'(resources: any, element: any, info: any, existingInstruction: any): any;
    'one-time'(resources: any, element: any, info: any, existingInstruction: any): any;
  }
Alxandr commented 9 years ago

Sure. Easy even. I just didn't know that was valid. I'll get right on it, just need to grab some food first.

On Fri, Oct 9, 2015, 18:09 Rob Eisenberg notifications@github.com wrote:

@Alxandr https://github.com/Alxandr Even thought the class members are declared without brackets, the resulting d.ts files contains brackets in the class definition. It's the brackets, within that particular context, that cause the TS compiler to fail. Would it be possible to update the d.ts generator plugin to not emit the brackets? That should fix the problem. The result should look something like this:

export class SyntaxInterpreter { static inject(): any; constructor(parser: any, observerLocator: any, eventManager: any); interpret(resources: any, element: any, info: any, existingInstruction: any): any; handleUnknownCommand(resources: any, element: any, info: any, existingInstruction: any): any; determineDefaultBindingMode(element: any, attrName: any): any; bind(resources: any, element: any, info: any, existingInstruction: any): any; trigger(resources: any, element: any, info: any): any; delegate(resources: any, element: any, info: any): any; call(resources: any, element: any, info: any, existingInstruction: any): any; options(resources: any, element: any, info: any, existingInstruction: any): any; 'for'(resources: any, element: any, info: any, existingInstruction: any): any; 'two-way'(resources: any, element: any, info: any, existingInstruction: any): any; 'one-way'(resources: any, element: any, info: any, existingInstruction: any): any; 'one-time'(resources: any, element: any, info: any, existingInstruction: any): any; }

— Reply to this email directly or view it on GitHub https://github.com/aurelia/templating-binding/pull/60#issuecomment-146913079 .

Alxandr

EisenbergEffect commented 9 years ago

No rush. Just let me know. On Oct 9, 2015 3:35 PM, "Alxandr" notifications@github.com wrote:

Sure. Easy even. I just didn't know that was valid. I'll get right on it, just need to grab some food first.

On Fri, Oct 9, 2015, 18:09 Rob Eisenberg notifications@github.com wrote:

@Alxandr https://github.com/Alxandr Even thought the class members are declared without brackets, the resulting d.ts files contains brackets in the class definition. It's the brackets, within that particular context, that cause the TS compiler to fail. Would it be possible to update the d.ts generator plugin to not emit the brackets? That should fix the problem. The result should look something like this:

export class SyntaxInterpreter { static inject(): any; constructor(parser: any, observerLocator: any, eventManager: any); interpret(resources: any, element: any, info: any, existingInstruction: any): any; handleUnknownCommand(resources: any, element: any, info: any, existingInstruction: any): any; determineDefaultBindingMode(element: any, attrName: any): any; bind(resources: any, element: any, info: any, existingInstruction: any): any; trigger(resources: any, element: any, info: any): any; delegate(resources: any, element: any, info: any): any; call(resources: any, element: any, info: any, existingInstruction: any): any; options(resources: any, element: any, info: any, existingInstruction: any): any; 'for'(resources: any, element: any, info: any, existingInstruction: any): any; 'two-way'(resources: any, element: any, info: any, existingInstruction: any): any; 'one-way'(resources: any, element: any, info: any, existingInstruction: any): any; 'one-time'(resources: any, element: any, info: any, existingInstruction: any): any; }

— Reply to this email directly or view it on GitHub < https://github.com/aurelia/templating-binding/pull/60#issuecomment-146913079

.

Alxandr

— Reply to this email directly or view it on GitHub https://github.com/aurelia/templating-binding/pull/60#issuecomment-146968940 .